Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support starting the driver, before the robot is booted #98

Merged
merged 5 commits into from
Apr 12, 2022
Merged

Support starting the driver, before the robot is booted #98

merged 5 commits into from
Apr 12, 2022

Conversation

urmahp
Copy link
Collaborator

@urmahp urmahp commented Apr 1, 2022

Refactored client library to support starting the client, before the robot is booted.

Changed producer to wait until robot is reachable on configured IP, instead of throwing an exception.

This will fix issue #94.

fmauch
fmauch reviewed Apr 1, 2022
View reviewed changes
Copy link
Collaborator

@fmauch fmauch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks mostly fine with me. Thank you @urmahp. This is a great contribution.

If you could address the mentioned formatting issues and maybe apply my comment suggestion, that would be great.

include/ur_client_library/rtde/rtde_client.h Outdated Show resolved Hide resolved
src/rtde/rtde_client.cpp Outdated Show resolved Hide resolved
src/rtde/rtde_client.cpp Outdated Show resolved Hide resolved
src/rtde/rtde_client.cpp Outdated Show resolved Hide resolved
src/rtde/rtde_client.cpp Outdated Show resolved Hide resolved
src/rtde/rtde_client.cpp Outdated Show resolved Hide resolved
src/rtde/rtde_client.cpp Outdated Show resolved Hide resolved
src/rtde/rtde_client.cpp Outdated Show resolved Hide resolved
src/rtde/rtde_client.cpp Outdated Show resolved Hide resolved
include/ur_client_library/rtde/rtde_client.h Outdated Show resolved Hide resolved
@fmauch
Copy link
Collaborator

fmauch commented Apr 1, 2022 •
edited
Loading

This will not completely fix #94 as we also have the connection to the secondary interface and to the dashboard server would need a reconnect to fully support starting the driver before a booted robot.

@urmahp would you like to address this in this PR, as well?

@urmahp
Copy link
Collaborator Author

urmahp commented Apr 1, 2022

This will not completely fix #94 as we also have the connection to the secondary interface and to the dashboard server would need a reconnect to fully support starting the driver before a booted robot.

@urmahp would you like to address this in this PR, as well?

If it can wait until next week, then I can have a look at it next week and address it in this PR.

@fmauch
Copy link
Collaborator

fmauch commented Apr 1, 2022

If it can wait until next week, then I can have a look at it next week and address it in this PR.

I would be fine with that. Maybe it will itch me enough before, to implement it myself, though ;-)

fmauch
fmauch approved these changes Apr 12, 2022
View reviewed changes
Copy link
Collaborator

@fmauch fmauch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I'll quickly add the missing dot in producer.h then we should be good to go.

include/ur_client_library/comm/producer.h Outdated Show resolved Hide resolved
urmahp and others added 5 commits April 12, 2022 21:04
@urmahp @fmauch
Support starting the driver, before the robot is booted
9b487fb 
Refactored client library to support starting the client, before the robot is booted.

Changed producer to wait until robot is reachable on configured IP, instead of throwing an exception.
@urmahp @fmauch
Fix formatting
0971378 
Co-authored-by: Felix Exner <felix_mauch@web.de>
@urmahp @fmauch
Move Set protocol version
1d76cb2 
Fix typo
@urmahp @fmauch
Move the endless connection attempts to the tcp socket
12330fe 
This will enable the dashboard client and secondary client to wait for a robot to be booted
@urmahp @fmauch
Fix formatting.
05533bc
@fmauch fmauch merged commit 387b21d into UniversalRobots:master Apr 12, 2022
@fmauch fmauch mentioned this pull request Apr 12, 2022
Closed
@urmahp urmahp deleted the startup branch April 22, 2022 05:46
@urmahp urmahp mentioned this pull request Apr 22, 2022
Open
urmahp added a commit to urmahp/Universal_Robots_Client_Library that referenced this pull request Sep 5, 2022
@urmahp @fmauch
Support starting the driver, before the robot is booted (UniversalRob…
99ec950 
…ots#98)

* Support starting the driver, before the robot is booted

Refactored client library to support starting the client, before the robot is booted.

Changed producer to wait until robot is reachable on configured IP, instead of throwing an exception.

* Move the endless connection attempts to the tcp socket

This will enable the dashboard client and secondary client to wait for a robot to be booted

* Fix formatting.

Co-authored-by: Felix Exner <felix_mauch@web.de>
@jornb jornb mentioned this pull request Mar 16, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmauch fmauch fmauch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@urmahp @fmauch