Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fake_components -> mock_components #37

Merged
merged 1 commit into from Sep 21, 2022

Conversation

Abishalini
Copy link
Contributor

@Abishalini Abishalini commented Aug 8, 2022

This was caused by a change in ros2_control: ros-controls/ros2_control@1967cfa

I need this change to work with fake hardware.

@fmauch
Copy link
Collaborator

fmauch commented Sep 16, 2022

Thank you for that PR. I'll have a look into which versions this actually affects and then decide how to proceed further.

Edit: Looks like we need to branch out for galactic before merging this.

@fmauch
Copy link
Collaborator

fmauch commented Sep 21, 2022

@Abishalini what kind of error did you experience? I've tried to reproduce the problems you had as I would have liked to catch that using a test, but I noticed that fake_hardware still seems to be functioning, which is no surprise if we take a look at https://github.com/ros-controls/ros2_control/blob/1967cfa179248ce2e72f4f974f20d6e19fe56da4/hardware_interface/fake_components_plugin_description.xml.

Copy link
Collaborator

@fmauch fmauch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks for fixing this @Abishalini

@fmauch fmauch merged commit c4d1724 into UniversalRobots:ros2 Sep 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants