Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch fake to mock for ros2_control updates #77

Merged
merged 2 commits into from
Jul 11, 2023
Merged

Switch fake to mock for ros2_control updates #77

merged 2 commits into from
Jul 11, 2023

Conversation

sea-bass
Copy link
Contributor

This PR updates "mock" to "fake" in the ros2_control parameters so it works correctly with the latest version (see linked issue).

Closes #76

fmauch
fmauch approved these changes Jul 11, 2023
View reviewed changes
Copy link
Collaborator

@fmauch fmauch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much @sea-bass We didn't want to switch too early in order to avoid having to branch out for versions not supporting mock but then we seem to have forgotten this.

@fmauch fmauch changed the base branch from humble to ros2 July 11, 2023 06:27
@fmauch fmauch linked an issue Jul 11, 2023 that may be closed by this pull request
Mock hardware xacro syntax is deprecated in latest ros2_control #76
Closed
@fmauch fmauch merged commit aedef36 into UniversalRobots:ros2 Jul 11, 2023
4 checks passed
@fmauch fmauch mentioned this pull request Jul 11, 2023
Merged
@sea-bass
Copy link
Contributor Author

sea-bass commented Jul 11, 2023 •
edited

Thank you very much @sea-bass We didn't want to switch too early in order to avoid having to branch out for versions not supporting mock but then we seem to have forgotten this.

Thanks! Will this need a forward port to main as well? Or do you guys do merges periodically?

@fmauch
Copy link
Collaborator

fmauch commented Jul 11, 2023

Yes, this will get propagated.

fmauch added a commit to fmauch/Universal_Robots_ROS2_Description that referenced this pull request Jul 12, 2023
@fmauch
Revert "Switch fake to mock for ros2_control updates (UniversalRobots#77
3958625 
)"

This reverts commit aedef36.

Since it was only a deprecation warning, there is no need to break API
on humble.
RobertWilbrandt pushed a commit that referenced this pull request Jul 13, 2023
@fmauch @RobertWilbrandt
Revert "Switch fake to mock for ros2_control updates (#77)"
c805a88 
This reverts commit aedef36.

Since it was only a deprecation warning, there is no need to break API
on humble.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmauch fmauch fmauch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Mock hardware xacro syntax is deprecated in latest ros2_control
2 participants
@sea-bass @fmauch