Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed the order of multiplication when calculating quaternion based… #15

Merged
merged 3 commits into from
Jun 12, 2024

Conversation

urmahp
Copy link
Contributor

@urmahp urmahp commented Aug 11, 2022

… vel and acc

This is done since the velocity and acceleration is given in the body-local reference frame.

The math supporting this change, can be found here.

I will try to think about a test, that could cover these changes.

… vel and acc

This is done since the velocity and acceleration is given in the body-local reference frame.
This adds test for
 * For conversion between spline state and cartesian state
 * Interpolation of orientation
@urmahp
Copy link
Contributor Author

urmahp commented Jan 9, 2023

Added test to cover the changes.

I don't know why the format check is complaining...

@urrsk
Copy link
Member

urrsk commented Dec 20, 2023

It seems this PR has been forgotten!
Will someone review this?

Copy link
Collaborator

@fmauch fmauch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for taking care about this @urmahp

@fmauch fmauch merged commit 5e06e5a into UniversalRobots:main Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants