Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle errors better #180

Open
Brookke opened this issue Feb 11, 2019 · 2 comments · May be fixed by #324
Open

Handle errors better #180

Brookke opened this issue Feb 11, 2019 · 2 comments · May be fixed by #324
Labels
good first issue

Comments

@Brookke
Copy link
Member

Brookke commented Feb 11, 2019

Rather than crashing the site completely, instead hide that section or display a message such as “Sorry podcasts do not seem to be available at this time”
@Brookke
Copy link
Member Author

Brookke commented Feb 11, 2019

Somewhat related but see
https://github.com/UniversityRadioYork/2016-site/blob/development/controllers/on_demand.go#L29-L33

Where the err of one is overwritten by another

@Brookke
Copy link
Member Author

Brookke commented Feb 11, 2019

Should be a simple improvement. Steps:

  1. Write a check to see if a method has returned an error, if it has then make the actual variable empty.
  2. Look over the corresponding template and add a statement to check to see if a variable is empty and if it is display a message instead.

@markspolakovs markspolakovs mentioned this issue May 14, 2021
Open
@markspolakovs markspolakovs linked a pull request Oct 16, 2022 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve error handling in controllers UniversityRadioYork/2016-site
1 participant
@Brookke