Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

/podcast/:id/player ignores suspended flag #269

Open
markspolakovs opened this issue Oct 15, 2020 · 1 comment · May be fixed by #330
Open

/podcast/:id/player ignores suspended flag #269

markspolakovs opened this issue Oct 15, 2020 · 1 comment · May be fixed by #330

Comments

@markspolakovs
Copy link
Member

markspolakovs commented Oct 15, 2020 •
edited
Loading

To reproduce:

  1. find a suspended podcast
  2. go to /podcasts/:id
  3. observe a 404 page
  4. go to /podcasts/:id/player
  5. observe Not a 404 page
@markspolakovs
Copy link
Member Author

See also #268

MattWindsor91 added a commit that referenced this issue Jul 30, 2023
@MattWindsor91
podcasts: improve check for unpublished podcasts
b220e4e 
The check occurs at the model level,
so anything that retrieves podcasts will now ignore unpublished ones.

This commit doesn't implement 404 handling for missing podcasts in the player,
so this currently just triggers a 200 and a blank screen.

Fixes #269.
@MattWindsor91 MattWindsor91 linked a pull request Jul 30, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve podcast handling UniversityRadioYork/2016-site
1 participant
@markspolakovs