Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show is misleading #12

Open
MattWindsor91 opened this issue Oct 6, 2016 · 1 comment
Open

Show is misleading #12

MattWindsor91 opened this issue Oct 6, 2016 · 1 comment
Assignees
@ChrisTheBaron

Comments

@MattWindsor91
Copy link
Member

We have two struct types, Show and ShowMeta. Of these, ShowMeta actually represents a show (and other places eg. the website internally call this thing a show). Show seems to be a mix of things relating to timeslots and things relating to shows.

I was quite confused by this---is there anything better we can call Show so ShowMeta can be named Show? Why does Show (the existing one) exist in the first place---ideally it shouldn't be needed as timeslots should cover this information, is this a MyRadio problem?
@ChrisTheBaron ChrisTheBaron self-assigned this Oct 9, 2016
@ChrisTheBaron
Copy link
Member

I believe this was my bad, when I was writing these additional structs I didn't really understand what they actually represented 😝 I believe we should refactor to bring it inline with the api, so Show, Season, Timeslot, etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ChrisTheBaron ChrisTheBaron

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@MattWindsor91 @ChrisTheBaron