New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make api url configurable somehow #23

Open

ChrisTheBaron opened this issue Oct 24, 2016 · 1 comment

Member

ChrisTheBaron commented Oct 24, 2016

https://github.com/UniversityRadioYork/myradio-go/blob/master/api.go#L20

func NewSession(apikey string) (*Session, error) {
    url, err := url.Parse(`https://ury.york.ac.uk/api/v2`)
    if err != nil {
        return nil, err
    }
...

ChrisTheBaron mentioned this issue

Make myradio-go more mockable #22

Merged

Member

MattWindsor91 commented Apr 12, 2017 •

edited

Loading

I agree, and was thinking about this myself when working on #35.

What would be the best way of doing this, except for moving the need to supply the URL to the user eg.

func NewSession(url url.URL, apikey string) { /* ... */ }

and maybe providing something like

var MyRadioURL = url.URL{ /* ... */ }

?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment