Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sus naming of podcast endpoint (session.Get) #66

Open
MattWindsor91 opened this issue Jul 30, 2023 · 0 comments
Open

Sus naming of podcast endpoint (session.Get) #66

MattWindsor91 opened this issue Jul 30, 2023 · 0 comments

Comments

@MattWindsor91
Copy link
Member

This method, in podcast.go, is presumably supposed to be named something like GetPodcast (or be Get on a podcast related type), but is instead named session.Get:

myradio-go/podcast.go

Lines 23 to 28 in 6858956

// Get retrieves the data for a single podcast from MyRadio given it's ID.
// This consumes one API request.
func (s *Session) Get(id int) (podcast *Podcast, err error) {
err = s.getf("/podcast/%d", id).Into(&podcast)
return
}

That name is ambiguous and also might theoretically clash with any other model that can be got using a Session. Can we rename this, or do things upstream now depend on this name?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant