irc controllers should default to superop not nobody permission level

ClassiCube · Feb 26, 2021 · 0eeff1f · 0eeff1f
1 parent fff3c50
commit 0eeff1f
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 7 deletions.
diff --git a/GUI/PropertyWindow/PropertyWindow.IRCSql.cs b/GUI/PropertyWindow/PropertyWindow.IRCSql.cs
@@ -64,7 +64,7 @@ public partial class PropertyWindow : Form {
             Server.Config.IRCShowWorldChanges = irc_cbWorldChanges.Checked;
             Server.Config.IRCShowAFK = irc_cbAFK.Checked;
 
-            Server.Config.IRCControllerRank = GuiPerms.GetPermission(irc_cmbRank, LevelPermission.Nobody);
+            Server.Config.IRCControllerRank = GuiPerms.GetPermission(irc_cmbRank, LevelPermission.Admin);
             Server.Config.IRCVerify = (IRCControllerVerify)irc_cmbVerify.SelectedIndex;
             Server.Config.IRCCommandPrefix = irc_txtPrefix.Text;
 

diff --git a/GUI/Window/Window.Players.cs b/GUI/Window/Window.Players.cs
@@ -51,7 +51,7 @@ public partial class Window : Form {
             string cmdName = args[0], cmdArgs = args.Length > 1 ? args[1] : "";
 
             CommandData data = default(CommandData);
-            data.Rank = LevelPermission.Nobody;
+            data.Rank    = LevelPermission.Nobody;
             data.Context = CommandContext.SendCmd;
             curPlayer.HandleCommand(cmdName, cmdArgs, data);
 

diff --git a/MCGalaxy/Generator/HeightmapGen.cs b/MCGalaxy/Generator/HeightmapGen.cs
@@ -26,10 +26,11 @@
 namespace MCGalaxy.Generator {
     public static class HeightmapGen {
 
-        static void OnDecodeError(Player p, Bitmap bmp) {
-            if (bmp != null) bmp.Dispose();                
+        static void OnDecodeError(Player p, Bitmap bmp) {
+            if (bmp != null) bmp.Dispose();
+            // TODO failed to decode the image. make sure you are using the URL of the image directly, not just the webpage it is hosted on              
             p.Message("&WThere was an error reading the downloaded image.");
-            p.Message("&WThe url may need to end with its extension (such as .jpg).");
+            p.Message("&WThe url may need to end with its extension (such as .jpg).");
         }
 
         public static Bitmap DecodeImage(byte[] data, Player p) {

diff --git a/MCGalaxy/Server/ServerConfig.cs b/MCGalaxy/Server/ServerConfig.cs
@@ -190,8 +190,8 @@ public sealed class ServerConfig : EnvConfig {
         public string IRCCommandPrefix = ".x";
         [ConfigEnum("irc-controller-verify", "IRC bot", IRCControllerVerify.HalfOp, typeof(IRCControllerVerify))]
         public IRCControllerVerify IRCVerify = IRCControllerVerify.HalfOp;
-        [ConfigPerm("irc-controller-rank", "IRC bot", LevelPermission.Nobody)]
-        public LevelPermission IRCControllerRank = LevelPermission.Nobody;       
+        [ConfigPerm("irc-controller-rank", "IRC bot", LevelPermission.Admin)]
+        public LevelPermission IRCControllerRank = LevelPermission.Admin;
 
         [ConfigBool("tablist-rank-sorted", "Tablist", true)]
         public bool TablistRankSorted = true;