Fix alts message sometimes showing to lower ranked players while hidd…

…en (Thanks Venk) Also make /info extra permission slightly more generic
ClassiCube · Jun 2, 2022 · 3344b18 · 3344b18
1 parent 5df9c88
commit 3344b18
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/MCGalaxy/Commands/Information/CmdWhois.cs b/MCGalaxy/Commands/Information/CmdWhois.cs
@@ -25,7 +25,7 @@ public sealed class CmdWhois : Command2 {
         public override string type { get { return CommandTypes.Information; } }
         public override bool UseableWhenFrozen { get { return true; } }
         public override CommandPerm[] ExtraPerms {
-            get { return new[] { new CommandPerm(LevelPermission.AdvBuilder, "can see player's IP and if on whitelist") }; }
+            get { return new[] { new CommandPerm(LevelPermission.AdvBuilder, "can see sensitive player information (e.g. IP)") }; }
         }
         public override CommandAlias[] Aliases {
             get { return new CommandAlias[] { new CommandAlias("Info"), new CommandAlias("i") }; }

diff --git a/MCGalaxy/Player/Player.Login.cs b/MCGalaxy/Player/Player.Login.cs
@@ -83,8 +83,6 @@ public partial class Player : IDisposable
             TotalTime = TimeSpan.FromSeconds(1);
             GetPlayerStats();
             ShowWelcome();
-
-            Server.Background.QueueOnce(ShowAltsTask, name, TimeSpan.Zero);
             CheckState();
 
             PlayerDB.LoadNick(this);
@@ -104,7 +102,9 @@ public partial class Player : IDisposable
 
             OnPlayerConnectEvent.Call(this);
             if (cancellogin) { cancellogin = false; return; }
-
+
+            Server.Background.QueueOnce(ShowAltsTask, name, TimeSpan.Zero);
+
             string joinMsg = "&a+ λFULL &S" + PlayerDB.GetLoginMessage(this);
             if (hidden) joinMsg = "&8(hidden)" + joinMsg;