Skip to content
This repository has been archived by the owner on Sep 3, 2021. It is now read-only.

Broken downstream builds #15

Closed
AndrewBurian opened this issue Mar 18, 2017 · 3 comments
Closed

Broken downstream builds #15

AndrewBurian opened this issue Mar 18, 2017 · 3 comments

Comments

@AndrewBurian
Copy link

Just an FYI, this commit 0db4a62 changed the AESDecrypt function interface, which broke your routing package macaron, which in turn broke the entire build of the http routing bechmark project that you submitted that router to.

Go relies on having a stable HEAD for all github sources. If you're going to commit your projects as modules to other projects, be a good member of the community and commit to stable interfaces. Especially since you declared a v1.0 release on this project which should indicate your interfaces are now stable.

@unknwon
Copy link
Owner

unknwon commented Mar 18, 2017

Hi,

  1. It is using https://github.com/Unknwon/macaron and it has been deprecated for over a year.
  2. Version 1 is ONLY ever tagged for https://github.com/go-macaron/macaron.
  3. I'll submit a PR but no guarantee they'll accept.

@unknwon
Copy link
Owner

unknwon commented Mar 18, 2017

I think I'll just update github.com/Unknwon/macaron, that seems easier.

@unknwon
Copy link
Owner

unknwon commented Mar 18, 2017

Should be good now unknwon/macaron@46ba718.

@unknwon unknwon closed this as completed Mar 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants