Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

startClient not working as expected #163

Closed
duveborg opened this issue Mar 6, 2024 · 1 comment
Closed

startClient not working as expected #163

duveborg opened this issue Mar 6, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@duveborg
Copy link

duveborg commented Mar 6, 2024

Describe the bug

<FlagProvider startClient={false}>

Providing false here seem to fire network requests to fetch flags. Is that expected?

Steps to reproduce the bug

No response

Expected behavior

No response

Logs, error output, etc.

No response

Screenshots

No response

Additional context

No response

Unleash version

No response

Subscription type

None

Hosting type

None

SDK information (language and version)

No response

@duveborg duveborg added the bug Something isn't working label Mar 6, 2024
@FredrikOseberg
Copy link
Contributor

FredrikOseberg commented Mar 15, 2024

Describe the bug

<FlagProvider startClient={false}>

Providing false here seem to fire network requests to fetch flags. Is that expected?

Steps to reproduce the bug

No response

Expected behavior

No response

Logs, error output, etc.

No response

Screenshots

No response

Additional context

No response

Unleash version

No response

Subscription type

None

Hosting type

None

SDK information (language and version)

No response

@duveborg

If you are not passing a custom client and on a version less than 4.2.2 it is expected, because it previously only applied if you passed a custom client. In 4.2.2 we merged this PR which also makes this functionality work with passing a config. Be aware that if you are passing a config there is no way to start the client afterwards.

@Tymek Tymek closed this as completed Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

No branches or pull requests

3 participants