Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internal only helpers.go makes custom gradual rollout strategies difficult/messy #42

Closed
GrgDev opened this issue May 3, 2019 · 5 comments

Comments

@GrgDev
Copy link

GrgDev commented May 3, 2019

I am currently writing some custom strategies that are simply gradual rollout strategies similar to the built in one for user IDs but these are keyed off of different data specific to my use case. I want to make sure that my gradual rollout strategy uses the same normalization, rounding, etc. that the built in gradual rollout strategies use.

However, that logic is defined inside of internal/strategies/helpers.go which means I don't get access to that by just importing. I have to copy & paste the helper.go code into my repo and remember to occasionally check to see if there's been any code changes to the helper.go file in this repo once in awhile. I believe this is less than ideal. I would appreciate it if these helper functions could be exported in some manner so as to make them available for import into custom strategies.

@jrbarron
Copy link
Collaborator

jrbarron commented May 5, 2019

@GrgDev Yup, that makes sense. How about we move them to the strategy package and export them? Sound like the right place? Are you using the v3 version of the client? Do you want to make a PR or should I do it?

@GrgDev
Copy link
Author

GrgDev commented May 6, 2019

I'll give it a shot.

@GrgDev
Copy link
Author

GrgDev commented May 7, 2019

Oh, I answered the last question but not the others. Yes, I am using the v3 version of the client. Also that package location sounds logical to me. I'll give making a PR a shot.

@FredrikOseberg
Copy link
Contributor

FredrikOseberg commented Jul 5, 2021

If anyone wants to take a stab at this it would require:

  • Move strategies package from internal folder structure to -> ROOTDIR/strategies/[packagefiles.go]
  • Verify that everything still works as expected

@stale
Copy link

stale bot commented Jul 7, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jul 7, 2022
@stale stale bot closed this as completed Jul 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants