-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Internal only helpers.go makes custom gradual rollout strategies difficult/messy #42
Comments
@GrgDev Yup, that makes sense. How about we move them to the |
I'll give it a shot. |
Oh, I answered the last question but not the others. Yes, I am using the v3 version of the client. Also that package location sounds logical to me. I'll give making a PR a shot. |
If anyone wants to take a stab at this it would require:
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
I am currently writing some custom strategies that are simply gradual rollout strategies similar to the built in one for user IDs but these are keyed off of different data specific to my use case. I want to make sure that my gradual rollout strategy uses the same normalization, rounding, etc. that the built in gradual rollout strategies use.
However, that logic is defined inside of
internal/strategies/helpers.go
which means I don't get access to that by just importing. I have to copy & paste the helper.go code into my repo and remember to occasionally check to see if there's been any code changes to the helper.go file in this repo once in awhile. I believe this is less than ideal. I would appreciate it if these helper functions could be exported in some manner so as to make them available for import into custom strategies.The text was updated successfully, but these errors were encountered: