Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/flush metrics #415

Merged
merged 2 commits into from
Jan 17, 2023
Merged

Feat/flush metrics #415

merged 2 commits into from
Jan 17, 2023

Conversation

ivarconr
Copy link
Member

@ivarconr ivarconr commented Jan 16, 2023 •
edited

Adds a flush metrics method, making it easier to gracefully shutdown the SDK and capture the last bucket of metrics.

This one looks a bit messy because it was built directly on top of #414

@coveralls
Copy link

coveralls commented Jan 16, 2023 •
edited

Coverage Status

Coverage: 91.423% (-0.6%) from 92.01% when pulling c3d9527 on feat/flushMetrics into e4c2963 on main.

sighphyre
sighphyre approved these changes Jan 17, 2023
View reviewed changes
Copy link
Member

@sighphyre sighphyre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ivarconr ivarconr merged commit 8dd7655 into main Jan 17, 2023
@ivarconr ivarconr deleted the feat/flushMetrics branch January 17, 2023 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sighphyre sighphyre sighphyre approved these changes

@chriswk chriswk Awaiting requested review from chriswk

Assignees
No one assigned
Labels
None yet
Projects
Issues and PRs
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ivarconr @coveralls @sighphyre