Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: flexible-rollout random stickiness is not random enough #417

Merged
merged 1 commit into from
Jan 17, 2023
Merged

fix: flexible-rollout random stickiness is not random enough #417

merged 1 commit into from
Jan 17, 2023

Conversation

ivarconr
Copy link
Member

It's easy to get skew when we only pick numbers between 0 and 100.

@ivarconr
fix: flexible-rollout random stickiness is not random enough
a4a9d47 
It's easy to get skew when we only pick numbers between 0 and 100.
@coveralls
Copy link

coveralls commented Jan 17, 2023 •
edited

Coverage Status

Coverage: 92.01%. Remained the same when pulling a4a9d47 on fix/random-must-be-random into e4c2963 on main.

gardleopard
gardleopard approved these changes Jan 17, 2023
View reviewed changes
Copy link

@gardleopard gardleopard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. better with random than radnom as well:D

@ivarconr ivarconr merged commit cc5b40e into main Jan 17, 2023
@ivarconr ivarconr deleted the fix/random-must-be-random branch January 17, 2023 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gardleopard gardleopard gardleopard approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Issues and PRs
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ivarconr @coveralls @gardleopard