Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow SDK to startup when backup data is corrupt #418

Merged
merged 2 commits into from
Jan 19, 2023

Conversation

sighphyre
Copy link
Member

This moves the error that's emitted when the SDK encounters a corrupted JSON backup file to rather be a warning. The backup file shouldn't block the startup sequence, even when it's broken, since the next API hit will cause the SDK to rewrite the file with clean data

@coveralls
Copy link

coveralls commented Jan 18, 2023

Coverage Status

Coverage: 91.813% (+0.4%) from 91.423% when pulling b39d465 on move-backupfile-parse-fail-to-warning into cc5b40e on main.

Copy link
Member

@nunogois nunogois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sighphyre sighphyre merged commit be165b5 into main Jan 19, 2023
@sighphyre sighphyre deleted the move-backupfile-parse-fail-to-warning branch January 19, 2023 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants