Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: always resolve startUnleash promise #442

Merged
merged 1 commit into from
Apr 9, 2023
Merged

fix: always resolve startUnleash promise #442

merged 1 commit into from
Apr 9, 2023

Conversation

fooddilsn
Copy link
Contributor

About the changes

startUnleash should wait for the synchronized event only when the Unleash instance isn't already synchronized.
Without the changes introduced by this PR, any subsequent invocation of startUnleash will produce an unresolved promise.

Closes #441

@coveralls
Copy link

coveralls commented Apr 7, 2023 •
edited

Coverage Status

Coverage: 91.085% (+0.03%) from 91.058% when pulling d3ae411 on fooddilsn:fix/start-unleash-unresolved into 008bcff on Unleash:main.

@ivarconr
Copy link
Member

ivarconr commented Apr 9, 2023

Thank you @fooddilsn

@ivarconr ivarconr merged commit 796bdc5 into Unleash:main Apr 9, 2023
6 checks passed
@fooddilsn fooddilsn deleted the fix/start-unleash-unresolved branch April 11, 2023 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivarconr ivarconr ivarconr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Issues and PRs
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

startUnleash functions doesn't return when called multiple times
3 participants
@fooddilsn @coveralls @ivarconr