refactor: one parent dependency check #531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kwasniew
commented
Oct 18, 2023
| @@ -131,7 +125,7 @@ export default class UnleashClient extends EventEmitter { | |||
| return { enabled: fallback() }; | |||
| } | |||
|
|
|||
| if (!feature || !feature.enabled) { | |||
| if (!feature || !this.isParentDependencySatisfied(feature, context) || !feature.enabled) { | |||
There was a problem hiding this comment.
by moving parent dependency check to isFeatureEnabled we can simplify isEnabled method and resolveVariant since both of those methods call isFeatureEnabled under the hood.
Tymek
approved these changes
Oct 18, 2023
| @@ -131,7 +125,7 @@ export default class UnleashClient extends EventEmitter { | |||
| return { enabled: fallback() }; | |||
| } | |||
|
|
|||
| if (!feature || !feature.enabled) { | |||
| if (!feature || !this.isParentDependencySatisfied(feature, context) || !feature.enabled) { | |||
There was a problem hiding this comment.
Suggested change
| if (!feature || !this.isParentDependencySatisfied(feature, context) || !feature.enabled) { | |
| if (!feature || !feature.enabled || !this.isParentDependencySatisfied(feature, context)) { |
There was a problem hiding this comment.
I wanted to be backwards compatible and check dependency before the feature itself. We had a failing test otherwise. Of course we can change the assumption.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the changes
Reduced number of calls to parent dependency check.
Important files
Discussion points