Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore: Make all events extend AbstractEvent #96

Closed
RikudouSage opened this issue Jun 20, 2022 · 0 comments · Fixed by #101
Closed

Chore: Make all events extend AbstractEvent #96

RikudouSage opened this issue Jun 20, 2022 · 0 comments · Fixed by #101
Assignees
@RikudouSage

Comments

@RikudouSage
Copy link
Collaborator

RikudouSage commented Jun 20, 2022 •
edited
Loading

Currently every event class file needs to check if the Symfony event dispatcher is installed and load event stub if it isn't. This should be done in one parent abstract class (introduced in #97).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RikudouSage RikudouSage

Labels
None yet
Projects
Issues and PRs
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Enhancement: Make all events extend one parent Unleash/unleash-client-php
1 participant
@RikudouSage