-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Impression Events #238
Comments
What event system would you like to use? I haven't used them much myself, but from a quick Google it doesn't look like there's a clear favorite. blinker seems reasonably popular, updated, and parts of the pallets project. |
Honestly, I'm in exactly the same boat. I've never needed an event system in Python so I have no opinions here. Blinker looks pretty reasonable. I think we should go with that |
eventsourcing is another one! (Just tossing research here while I 🤔 |
@sighphyre What GUID format do you expect for events? Here are the standard options for Python. |
Any reason not to use a uuidv4()? That's my go to unless I need something special |
I have seen some tweaks (i.e. namespacing) for massively distributed systems...but I suspect in most cases it's overkill and I'll start with uuidv4() and we can see how if it fowls up in the wild... |
This is a feature that's implemented in most of the Unleash SDKs, it's currently not implemented here.
Reference documentation here: https://docs.getunleash.io/reference/impression-data
And reference PR implementing this in the dotnet SDK: Unleash/unleash-client-dotnet#113
The text was updated successfully, but these errors were encountered: