Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RestController Documentation #30

Closed
malte-baumann opened this issue Apr 5, 2024 · 2 comments · Fixed by #31
Closed

RestController Documentation #30

malte-baumann opened this issue Apr 5, 2024 · 2 comments · Fixed by #31

Comments

@malte-baumann
Copy link
Contributor

I believe the Example of an RestController in the README File contains a wrong annotation.

What it says:

@GetMapping
    public String feature(@RequestMapping @Context(name = "name") final String name) {
        return featureDemoService.getDemoString(name);
    }

What it should say:

@GetMapping
    public String feature(@RequestParam @Context(name = "name") final String name) {
        return featureDemoService.getDemoString(name);
    }
@daveleek
Copy link

daveleek commented Apr 8, 2024

Thank you for raising and fixing this @malte-baumann! Your PR has been approved, feel free to merge!

@daveleek
Copy link

daveleek commented Apr 8, 2024

Thank you @malte-baumann, we merged your PR and are closing this issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants