Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): change the remoteAddress description #1539

Merged
merged 1 commit into from
Apr 28, 2022

Conversation

thomasheartman
Copy link
Contributor

This PR fixes a duplicated description in the Unleash Context's field overview: remoteAddress seems to use the sessionId description.

Discussion points

Is this correct? And is it the right way to phrase it?

@vercel
Copy link

vercel bot commented Apr 27, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
unleash-docs ✅ Ready (Inspect) Visit Preview Apr 27, 2022 at 11:41AM (UTC)

@github-actions
Copy link

Coverage report

St.
Category Percentage Covered / Total
🟢 Statements 91.17% 5174/5675
🟡 Branches 79.31% 809/1020
🟢 Functions 86.19% 1217/1412
🟢 Lines 91.09% 5053/5547

Test suite run success

858 tests passing in 124 suites.

Report generated by 🧪jest coverage report action from 046bddc

Copy link
Contributor

@chriswk chriswk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we're saying "the app" for environment as well, the app's IP address seems fine.

Copy link
Member

@sighphyre sighphyre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thomasheartman thomasheartman merged commit 05f4cbb into main Apr 28, 2022
@thomasheartman thomasheartman deleted the fix/update-context-remote-addr branch April 28, 2022 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants