-
-
Notifications
You must be signed in to change notification settings - Fork 658
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: project environments order #1599
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't necessarily have a problem with this change but a join and a sort is a bit of a computational cost on the db side. Should be a cold path so this doesn't seem like a problem but I think it's probably worth unpacking a little bit what the pain is on the front end side. I'm happy to approve but I think a third set of eyes would be sensible.
As an aside, I don't think the test that was added here actually ran on the build, I see 868 total on the build output but 869 total on my machine. Pretty sure that's nothing to do with this PR but it's definitely worth understanding
cd4e48c
to
e0bbd54
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, looks good
edfbbae
to
3ace8b0
Compare
Coverage report
Show files with reduced coverage 🔻
Test suite run success870 tests passing in 124 suites. Report generated by 🧪jest coverage report action from 3ace8b0 |
About the changes
Environments in
/api/admin/projects/$id
are not sorted. Having it in correct order from backend will make new Single Project Overview - Features list table easier to implement.Important files
src/lib/db/project-store.ts