Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: project environments order #1599

Merged
merged 1 commit into from
May 23, 2022
Merged

fix: project environments order #1599

merged 1 commit into from
May 23, 2022

Conversation

Tymek
Copy link
Member

@Tymek Tymek commented May 16, 2022

About the changes

Environments in /api/admin/projects/$id are not sorted. Having it in correct order from backend will make new Single Project Overview - Features list table easier to implement.

Important files

src/lib/db/project-store.ts

@vercel
Copy link

vercel bot commented May 16, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
unleash-docs ⬜️ Ignored (Inspect) May 23, 2022 at 8:49AM (UTC)

@Tymek Tymek marked this pull request as ready for review May 16, 2022 13:35
Copy link
Member

@sighphyre sighphyre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't necessarily have a problem with this change but a join and a sort is a bit of a computational cost on the db side. Should be a cold path so this doesn't seem like a problem but I think it's probably worth unpacking a little bit what the pain is on the front end side. I'm happy to approve but I think a third set of eyes would be sensible.

As an aside, I don't think the test that was added here actually ran on the build, I see 868 total on the build output but 869 total on my machine. Pretty sure that's nothing to do with this PR but it's definitely worth understanding

src/lib/db/project-store.ts Outdated Show resolved Hide resolved
src/test/e2e/services/project-service.e2e.test.ts Outdated Show resolved Hide resolved
Copy link
Member

@sighphyre sighphyre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good

@Tymek Tymek force-pushed the fix/project-environments-order branch from edfbbae to 3ace8b0 Compare May 23, 2022 08:48
@Tymek Tymek enabled auto-merge (squash) May 23, 2022 08:51
@github-actions
Copy link

Coverage report

St.
Category Percentage Covered / Total
🟢 Statements 91.34% 5285/5786
🟡 Branches 79.16% 813/1027
🟢 Functions 86.16% 1226/1423
🟢 Lines 91.27% 5164/5658
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟡
... / openapi-service.ts
68.75% (-12.5% 🔻)
12.5% (-50% 🔻)
62.5% (-12.5% 🔻)
68.75% (-12.5% 🔻)

Test suite run success

870 tests passing in 124 suites.

Report generated by 🧪jest coverage report action from 3ace8b0

@Tymek Tymek merged commit 0f27268 into main May 23, 2022
@Tymek Tymek deleted the fix/project-environments-order branch May 23, 2022 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants