Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: use named export instead of default #1615

Merged
merged 1 commit into from
May 20, 2022

Conversation

nunogois
Copy link
Member

About the changes

Updated the docs to specify using the named FlagProvider export instead of the default export. Also fixed prop value format.

Keeps proxy-client usage consistent with proxy-client-react. See: Unleash/proxy-client-react#58

Discussion points

We might want to remove the default export at a later major version and only use named exports.

@vercel
Copy link

vercel bot commented May 20, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
unleash-docs ✅ Ready (Inspect) Visit Preview May 20, 2022 at 7:41AM (UTC)

Copy link
Contributor

@thomasheartman thomasheartman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perf 🥳 Good work 😄

@nunogois nunogois merged commit 40c920f into main May 20, 2022
@nunogois nunogois deleted the docs/import-flagprovider-svelte branch May 20, 2022 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants