Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: add regression test for long parameter values #1617

Merged
merged 2 commits into from
May 20, 2022
Merged

refactor: add regression test for long parameter values #1617

merged 2 commits into from
May 20, 2022

Conversation

olav
Copy link
Contributor

@olav olav commented May 20, 2022

No description provided.

@olav olav requested a review from FredrikOseberg May 20, 2022 11:08
@vercel
Copy link

vercel bot commented May 20, 2022 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
unleash-docs ✅ Ready (Inspect) Visit Preview May 20, 2022 at 11:17AM (UTC)

@github-actions
Copy link

github-actions bot commented May 20, 2022 •
edited

Coverage report

St.❔
 Category Percentage Covered / Total
🟢 Statements 91.34% 5285/5786
🟡 Branches 79.16% 813/1027
🟢 Functions 86.16% 1226/1423
🟢 Lines 91.27% 5164/5658
Show files with reduced coverage 🔻
St.❔
 File Statements Branches Functions Lines
🟡
... / openapi-service.ts
68.75% (-12.5% 🔻)
12.5% (-50% 🔻)
62.5% (-12.5% 🔻)
68.75% (-12.5% 🔻)

Test suite run success

869 tests passing in 124 suites.

Report generated by 🧪jest coverage report action from 9c9ec40

FredrikOseberg
FredrikOseberg approved these changes May 20, 2022
View reviewed changes
Copy link
Contributor

@FredrikOseberg FredrikOseberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@olav olav merged commit b53912a into main May 20, 2022
@olav olav deleted the parameters-length-test branch May 20, 2022 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FredrikOseberg FredrikOseberg FredrikOseberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Issues and PRs
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@olav @FredrikOseberg