fix: deletes all sessions for user on logout #2071
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ |
Coverage report
Test suite run success1159 tests passing in 191 suites. Report generated by 🧪jest coverage report action from 180855a |
|
tests added both for invalidating sessions when changing password and for logging out |
gardleopard
reviewed
Sep 23, 2022
| app.use('/logout', new LogoutController(config, { sessionService }).router); | ||
| await supertest(app).get('/logout').expect(302); | ||
| let activeSessions = await sessionStore.getSessionsForUser(1); | ||
| expect(activeSessions).toHaveLength(0); |
gardleopard
approved these changes
Sep 23, 2022
| .post(`/api/admin/user-admin/${user.id}/change-password`) | ||
| .send({ password: 'simple123-_ASsad' }) | ||
| .expect(200); | ||
| expect(spy).toHaveBeenCalled(); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To ensure we clean up sessions on logout this PR does two things:
Will add a test before moving from draft