feat: new profile page and PATs front-end #2109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
![sonatype-lift[bot]](https://avatars.githubusercontent.com/in/9843?s=60&v=4){kind=small}
nunogois
force-pushed
the
user-profile
branch
from
b44201d
to
7f76a96
Compare
nunogois
force-pushed
the
user-profile
branch
from
f683f39
to
c401f8d
Compare
nunogois
changed the title
FredrikOseberg
requested changes
Sep 30, 2022
...omponent/user/Profile/PersonalAPITokensTab/CreatePersonalAPIToken/CreatePersonalAPIToken.tsx
Outdated
Show resolved
Hide resolved
|
@FredrikOseberg yes the password page should use PageContent to get the same appearance |
- add route logic to profile; - refactor TimeAgoCell title; - misc fixes and refactoring;
nunogois
force-pushed
the
user-profile
branch
from
ab4b44a
to
463d63c
Compare
|
Included fixes, refactoring and any other misc changes related to https://linear.app/unleash/issue/2-287/ui-adjustments-for-personal-api-token as well. |
FredrikOseberg
approved these changes
Oct 3, 2022
Comment on lines
59
to
66
| try { | ||
| const path = formatApiPath('api/admin/user/change-password'); | ||
| const res = await fetch(path, { | ||
| await fetch(path, { | ||
| headers, | ||
| body: JSON.stringify({ password, confirmPassword }), | ||
| method: 'POST', | ||
| credentials: 'include', | ||
| }); |
There was a problem hiding this comment.
This could be moved into an API hook
chriswk
reviewed
Oct 3, 2022
chriswk
approved these changes
Oct 3, 2022
FredrikOseberg
approved these changes
Oct 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://linear.app/unleash/issue/2-278/user-profile-page-front-end
Due to the way the work flowed, also includes: https://linear.app/unleash/issue/2-274/frontend-for-personal-api-tokens - I can split it into a separate PR if it's easier to review.
Also includes: