fix: add appName to http response time metrics #2117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ivarconr
force-pushed
the
fix/add-appname-to-request-metrics
branch
from
1577df8
to
7a8f79f
Compare
gardleopard
approved these changes
Sep 30, 2022
Good point. Added a experimental flag now, so we can enable it only for selected customers in production. When disabled we will always set |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the changes
This small fix adds a appName label to the
http_request_duration_millisecondsPrometheus metrics. It is taken from theunleash-appnameheader, used by all official Unleash SDKs. This makes it easier to debug chatty applications.