Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: url encode application name in links #2121

Merged
merged 2 commits into from
Sep 30, 2022
Merged

Conversation

gardleopard
Copy link
Contributor

This ensures that we url encode application names for our links.

This ensures that we url encode application names for our links.
@vercel
Copy link

vercel bot commented Sep 30, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
unleash-monorepo-frontend ✅ Ready (Inspect) Visit Preview Sep 30, 2022 at 1:34PM (UTC)
1 Ignored Deployment
Name Status Preview Updated
unleash-docs ⬜️ Ignored (Inspect) Sep 30, 2022 at 1:34PM (UTC)

@ivarconr
Copy link
Member

Makes sense, but seems to have some failing tests.

@gardleopard
Copy link
Contributor Author

fixed now :)

Copy link
Contributor

@gastonfournier gastonfournier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gardleopard gardleopard merged commit ba8bdc5 into main Sep 30, 2022
@gardleopard gardleopard deleted the url_encode_applications branch September 30, 2022 13:53
@mc0
Copy link

mc0 commented Sep 30, 2022

Hi -- I'm the one that reported this to support. I was able to mostly clean these up by doing something very similar via the API, but I actually ran into some that even this wasn't fixing. A few applications contained # which weren't being deleted by this approach.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

4 participants