fix: equality check on feature strategy #2145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
FredrikOseberg
added a commit
that referenced
this pull request
Oct 6, 2022
fix: add ability to format objects to perform equality checks on
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the changes
When we added equality checks on feature strategies, we failed to account for the fact that
lastUpdatedAtwill update on the feature toggle every time an SDK has asked for that feature. This triggers the stale data notification, because the feature toggle has in fact changed, but not in any meaningful way. Furthermore, it will trigger on every polling interval, which can be annoying for the user.This adds a formatter to the hook that allows you to decide how the data should look before performing the equality check.
Closes # .
Important files
Discussion points