fix: respect environment if set on context #2206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
ivarconr
reviewed
Oct 19, 2022
| properties: ['some'], | ||
| }); | ||
|
|
||
| expect(context.environment).toBe('development'); |
There was a problem hiding this comment.
I would like to see another test proving environment will not be development when not set on context.
ivarconr
reviewed
Oct 19, 2022
ivarconr
approved these changes
Oct 19, 2022
ivarconr
pushed a commit
that referenced
this pull request
Oct 19, 2022
When using the frontend api (embedded proxy) we should allow the use to self-define the environment on the proxy.
sighphyre
pushed a commit
that referenced
this pull request
Oct 27, 2022
When using the frontend api (embedded proxy) we should allow the use to self-define the environment on the proxy.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue with the new frontend API where we would override environment set on the context to what the environment of the API key was. This will break feature toggles for older users of unleash because some might still be using the deprecated environment field on the SDKs.
About the changes
Closes # .
Important files
Discussion points