Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: isPro check on change request configuration #2610

Merged
merged 1 commit into from
Dec 7, 2022

Conversation

nunogois
Copy link
Member

@nunogois nunogois commented Dec 6, 2022

https://linear.app/unleash/issue/2-487/bug-change-request-badge-is-not-working-on-pro
Using the new isPro() from useUiConfig() seems to fix this in Pro, correctly showing the premium feature info:

image

The errors described in the issue should be fixed by the new useEnterpriseSWR. See: https://unleash-internal.slack.com/archives/C046LV6HH6W/p1670337216187539?thread_ts=1670331887.521059&cid=C046LV6HH6W

@vercel
Copy link

vercel bot commented Dec 6, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
unleash-monorepo-frontend ✅ Ready (Inspect) Visit Preview Dec 6, 2022 at 3:49PM (UTC)
1 Ignored Deployment
Name Status Preview Updated
unleash-docs ⬜️ Ignored (Inspect) Dec 6, 2022 at 3:49PM (UTC)

Copy link
Contributor

@gardleopard gardleopard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

@nunogois nunogois merged commit 990b708 into main Dec 7, 2022
@nunogois nunogois deleted the fix-ispro-change-request-config branch December 7, 2022 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants