fix: found an edge case exporting variants #2900
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ |
gastonfournier
commented
Jan 13, 2023
| (fe) => fe.featureName === f.name, | ||
| )?.variants; | ||
| const variants = featureAndEnvs | ||
| .sort((e1, e2) => { |
There was a problem hiding this comment.
The sorting of the environments is not absolute, it depends on whether the feature in a particular project has that environment active or not plus the other conditions.
gastonfournier
deleted the
fix-export-when-default-project-is-disabled
branch
gastonfournier
pushed a commit
that referenced
this pull request
Jan 13, 2023
## About the changes When exporting v3, for variants backward compatibility, we need to find one featureEnvironment and fetch variants from there. In cases where the default environment is disabled (therefore does not get variants per environment when added), it can be still be selected for the export process. Therefore variants don't appear in the feature when they should be there. An e2e test that fails with the previous implementation was added to validate the behavior This comes from our support ticket 404
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the changes
When exporting v3, for variants backward compatibility, we need to find one featureEnvironment and fetch variants from there.
In cases where the default environment is disabled (therefore does not get variants per environment when added), it can be still be selected for the export process. Therefore variants don't appear in the feature when they should be there.
An e2e test that fails with the previous implementation was added to validate the behavior
This comes from our support ticket 404