fix: prevent deleting the last variable variant on the ui #2964
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
sighphyre
commented
Jan 23, 2023
...EnvironmentVariantsCard/EnvironmentVariantsTable/VariantsActionsCell/VariantsActionsCell.tsx
Show resolved
Hide resolved
sighphyre
commented
Jan 23, 2023
| return { patch: [], error: formatUnknownError(error) }; | ||
| } | ||
| const updatedNewVariants = updateWeight(newVariants, 1000); | ||
| return { patch: createPatch(variants, updatedNewVariants) }; |
There was a problem hiding this comment.
This allows the error to bubble back to the caller, which gives us a nice pretty error message. This should be prevented by the other changes for this error path but other cases can also cause failures, in which case an error message would be pretty cool
nunogois
approved these changes
Jan 23, 2023
| @@ -130,6 +131,23 @@ export const EnvironmentVariantsTable = ({ | |||
| [] | |||
| ); | |||
|
|
|||
| const isProtectedVariant = (variant: IFeatureVariant): boolean => { | |||
| const isVariable = variant.weightType === 'variable'; | |||
There was a problem hiding this comment.
I think we have some weight type constants around somewhere if you'd like to use those instead of a literal string.
There was a problem hiding this comment.
Yeah point, shot.
He wasn't exposed, so he got a new home in constants for reusing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This blocks the UI from allowing you to attempt to delete the last fixed variant in environment variants, this was previously possible, but the UI catch an error and then never make a request. For bonus points this removes the problematic try catch, which allows the error message to bubble correctly to the handler