feat: visualize variants diff in CR #2979
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nunogois
requested review from
gastonfournier,
kwasniew,
FredrikOseberg and
andreas-unleash
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://linear.app/unleash/issue/2-582/display-the-change-request-created-with-variants-in-the-ui
Includes a basic diff visualisation on variants change requests.
It seems like components like
CodeSnippetPopoverandPopoverDiffare currently very tightly coupled together with strategies, so I preferred to follow my own approach and leave those alone for now instead of trying to refactor them.patchVariantcould also be renamed to a more fitting name in the future as well, since we're now doing more of an override than applying a patch.Diffis a generic diff component that usesEventDiffinternally and simply takes into account a "before" and "after" state, aspreDataanddata.I made some changes to
EventDiffthat made some sense to me:pathis undefined and.joincrashes, also fallback to the diff index (or undefined);