feat: back transition from validate to configure #2982
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
kwasniew
commented
Jan 25, 2023
| const [importStage, setImportStage] = useState<ImportStage>({ | ||
| name: 'configure', | ||
| }); | ||
| const [importStage, setImportStage] = useState<ImportStage>('configure'); |
There was a problem hiding this comment.
moved state up to the parent to keep it for the entire flow
kwasniew
commented
Jan 25, 2023
| ...configuration, | ||
| }) | ||
| tabs={ | ||
| <ConfigurationTabs |
There was a problem hiding this comment.
this is a technique called "slots not props". Instead of prop drilling data I compose child components where the state is and pass them as ReactNodes.
kwasniew
commented
Jan 25, 2023
| environment: string; | ||
| payload: string; | ||
| } | ||
| export const ConfigurationTabs: FC<{ |
There was a problem hiding this comment.
configuration stage exposes small components. They can be composed in the parent who owns the state
kwasniew
commented
Jan 25, 2023
| ); | ||
|
|
||
| export const ConfigurationStage: FC<{ | ||
| tabs: ReactNode; |
There was a problem hiding this comment.
this is a typical signature for "slots not props" technique. ReactNode instead of lots of string fields
sjaanus
approved these changes
Jan 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the changes
Important files
Discussion points