Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: properly escaping app names #3368

Merged
merged 1 commit into from
Mar 22, 2023

Conversation

gastonfournier
Copy link
Contributor

@gastonfournier gastonfournier commented Mar 22, 2023

About the changes

Network overview was not escaping square brackets from app names and that caused mermaid graph to break. We've also identified problems with quotes and some characters not showing properly when using utf-8 (but still no solution for this). We're going to be testing the utf-8 issue in our sandbox instances.

@gastonfournier gastonfournier self-assigned this Mar 22, 2023
@vercel
Copy link

vercel bot commented Mar 22, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
unleash-monorepo-frontend ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 22, 2023 at 9:30AM (UTC)
1 Ignored Deployment
Name Status Preview Comments Updated
unleash-docs ⬜️ Ignored (Inspect) Mar 22, 2023 at 9:30AM (UTC)

Copy link
Member

@nunogois nunogois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@gastonfournier gastonfournier merged commit 64c41b8 into main Mar 22, 2023
@gastonfournier gastonfournier deleted the fix-network-with-square-brackets branch March 22, 2023 09:40
gastonfournier added a commit that referenced this pull request Mar 22, 2023
## About the changes
Network overview was not escaping square brackets from app names and
that caused mermaid graph to break. We've also identified problems with
quotes and some characters not showing properly when using utf-8 (but
still no solution for this). We're going to be testing the utf-8 issue
in our sandbox instances.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants