fix: stickiness #3471

andreas-unleash · 2023-04-06T12:53:57Z

Fixes project model/store
Fixes UI sync issues when switching stickiness

About the changes

Closes #

Important files

Discussion points

Signed-off-by: andreas-unleash <andreas@getunleash.ai>

vercel · 2023-04-06T12:54:03Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
unleash-docs	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Apr 6, 2023 2:09pm
unleash-monorepo-frontend	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Apr 6, 2023 2:09pm

github-actions · 2023-04-06T12:55:42Z

After enabling strictNullChecks this PR would be increasing the number of null check errors from 397 to 401.
Make sure your branch is up-to-date with main and check the diff in the console output to pinpoint the offending files.

Signed-off-by: andreas-unleash <andreas@getunleash.ai>

github-actions · 2023-04-06T13:04:51Z

After enabling strictNullChecks this PR would be increasing the number of null check errors from 397 to 401.
Make sure your branch is up-to-date with main and check the diff in the console output to pinpoint the offending files.

Signed-off-by: andreas-unleash <andreas@getunleash.ai>

github-actions · 2023-04-06T13:09:19Z

After enabling strictNullChecks this PR would be increasing the number of null check errors from 397 to 401.
Make sure your branch is up-to-date with main and check the diff in the console output to pinpoint the offending files.

Signed-off-by: andreas-unleash <andreas@getunleash.ai>

github-actions · 2023-04-06T13:16:09Z

After enabling strictNullChecks this PR would be increasing the number of null check errors from 397 to 401.
Make sure your branch is up-to-date with main and check the diff in the console output to pinpoint the offending files.

Signed-off-by: andreas-unleash <andreas@getunleash.ai>

github-actions · 2023-04-06T13:25:07Z

After enabling strictNullChecks this PR would be increasing the number of null check errors from 397 to 401.
Make sure your branch is up-to-date with main and check the diff in the console output to pinpoint the offending files.

Signed-off-by: andreas-unleash <andreas@getunleash.ai>

github-actions · 2023-04-06T13:30:20Z

After enabling strictNullChecks this PR would be increasing the number of null check errors from 397 to 401.
Make sure your branch is up-to-date with main and check the diff in the console output to pinpoint the offending files.

andreas-unleash · 2023-04-06T13:35:06Z

null checks failing is expected - its comparing with main

Signed-off-by: andreas-unleash <andreas@getunleash.ai>

github-actions · 2023-04-06T13:49:40Z

After enabling strictNullChecks this PR would be increasing the number of null check errors from 397 to 401.
Make sure your branch is up-to-date with main and check the diff in the console output to pinpoint the offending files.

kwasniew

Non blocking approve with a few comments left

kwasniew · 2023-04-06T13:43:03Z

...ureVariants/FeatureEnvironmentVariants/EnvironmentVariantsModal/EnvironmentVariantsModal.tsx

@@ -308,14 +314,13 @@ export const EnvironmentVariantsModal = ({
    }, [apiPayload.error]);

    const handleClose = () => {
-        updateStickiness(defaultStickiness).catch(console.warn);
+        updateStickiness(defaultStickiness).then();


empty then left

...ureVariants/FeatureEnvironmentVariants/EnvironmentVariantsModal/EnvironmentVariantsModal.tsx

kwasniew · 2023-04-06T13:59:21Z

One more thing. This PR increases the number of null check errors from 397 to 401. Since we're trying to bring this number down to 0 I'd try to keep the number same or even lower by paying down some tech debt.

Signed-off-by: andreas-unleash <andreas@getunleash.ai>

github-actions · 2023-04-06T14:02:21Z

After enabling strictNullChecks this PR would be increasing the number of null check errors from 397 to 401.
Make sure your branch is up-to-date with main and check the diff in the console output to pinpoint the offending files.

Signed-off-by: andreas-unleash <andreas@getunleash.ai>

github-actions · 2023-04-06T14:08:05Z

After enabling strictNullChecks this PR would be increasing the number of null check errors from 397 to 401.
Make sure your branch is up-to-date with main and check the diff in the console output to pinpoint the offending files.

fix: stickiness

0569e31

Signed-off-by: andreas-unleash <andreas@getunleash.ai>

vercel bot deployed to Preview – unleash-docs April 6, 2023 12:56 View deployment

fix: stickiness

9f88727

Signed-off-by: andreas-unleash <andreas@getunleash.ai>

vercel bot deployed to Preview – unleash-monorepo-frontend April 6, 2023 13:04 View deployment

vercel bot deployed to Preview – unleash-docs April 6, 2023 13:06 View deployment

fix: stickiness to fallback project

f0a68db

Signed-off-by: andreas-unleash <andreas@getunleash.ai>

vercel bot deployed to Preview – unleash-monorepo-frontend April 6, 2023 13:08 View deployment

vercel bot deployed to Preview – unleash-docs April 6, 2023 13:10 View deployment

fix: remove console.log

329f06c

Signed-off-by: andreas-unleash <andreas@getunleash.ai>

vercel bot deployed to Preview – unleash-docs April 6, 2023 13:15 View deployment

vercel bot deployed to Preview – unleash-monorepo-frontend April 6, 2023 13:17 View deployment

fix

e6da0b9

Signed-off-by: andreas-unleash <andreas@getunleash.ai>

vercel bot deployed to Preview – unleash-monorepo-frontend April 6, 2023 13:24 View deployment

vercel bot deployed to Preview – unleash-docs April 6, 2023 13:26 View deployment

andreas-unleash added 2 commits April 6, 2023 16:26

fix imports

26380f6

Signed-off-by: andreas-unleash <andreas@getunleash.ai>

improvement - cleaning up

650633c

Signed-off-by: andreas-unleash <andreas@getunleash.ai>

vercel bot deployed to Preview – unleash-monorepo-frontend April 6, 2023 13:28 View deployment

vercel bot deployed to Preview – unleash-docs April 6, 2023 13:31 View deployment

vercel bot deployed to Preview – unleash-monorepo-frontend April 6, 2023 13:34 View deployment

bug fix

ac373b9

Signed-off-by: andreas-unleash <andreas@getunleash.ai>

vercel bot deployed to Preview – unleash-monorepo-frontend April 6, 2023 13:40 View deployment

vercel bot deployed to Preview – unleash-docs April 6, 2023 13:41 View deployment

kwasniew approved these changes Apr 6, 2023

View reviewed changes

PR improvement

e6574b6

Signed-off-by: andreas-unleash <andreas@getunleash.ai>

vercel bot deployed to Preview – unleash-docs April 6, 2023 14:02 View deployment

vercel bot deployed to Preview – unleash-monorepo-frontend April 6, 2023 14:03 View deployment

PR improvement

c8c964a

Signed-off-by: andreas-unleash <andreas@getunleash.ai>

vercel bot deployed to Preview – unleash-monorepo-frontend April 6, 2023 14:07 View deployment

vercel bot deployed to Preview – unleash-docs April 6, 2023 14:09 View deployment

andreas-unleash changed the base branch from 4.22 to main April 6, 2023 14:11

andreas-unleash changed the base branch from main to 4.22 April 6, 2023 14:14

andreas-unleash merged commit 92328f6 into 4.22 Apr 6, 2023
9 of 14 checks passed

andreas-unleash deleted the tmp-4.22.3 branch April 6, 2023 14:17

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: stickiness #3471

fix: stickiness #3471

andreas-unleash commented Apr 6, 2023

vercel bot commented Apr 6, 2023 •

edited

github-actions bot commented Apr 6, 2023

github-actions bot commented Apr 6, 2023

github-actions bot commented Apr 6, 2023

github-actions bot commented Apr 6, 2023

github-actions bot commented Apr 6, 2023

github-actions bot commented Apr 6, 2023

andreas-unleash commented Apr 6, 2023 •

edited

github-actions bot commented Apr 6, 2023

kwasniew left a comment

kwasniew Apr 6, 2023

kwasniew commented Apr 6, 2023

github-actions bot commented Apr 6, 2023

github-actions bot commented Apr 6, 2023

fix: stickiness #3471

fix: stickiness #3471

Conversation

andreas-unleash commented Apr 6, 2023

About the changes

Important files

Discussion points

vercel bot commented Apr 6, 2023 • edited

github-actions bot commented Apr 6, 2023

github-actions bot commented Apr 6, 2023

github-actions bot commented Apr 6, 2023

github-actions bot commented Apr 6, 2023

github-actions bot commented Apr 6, 2023

github-actions bot commented Apr 6, 2023

andreas-unleash commented Apr 6, 2023 • edited

github-actions bot commented Apr 6, 2023

kwasniew left a comment

Choose a reason for hiding this comment

kwasniew Apr 6, 2023

Choose a reason for hiding this comment

kwasniew commented Apr 6, 2023

github-actions bot commented Apr 6, 2023

github-actions bot commented Apr 6, 2023

vercel bot commented Apr 6, 2023 •

edited

andreas-unleash commented Apr 6, 2023 •

edited