fix: correct error for missing context field #3647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When adding a strategy using a context field that did not exist, we threw an unknown error. This changes to throw NotFoundError so that our users can better know what they did wrong.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ |
sjaanus
approved these changes
Apr 28, 2023
kwasniew
approved these changes
Apr 28, 2023
There was a problem hiding this comment.
Interesting. I'd usually expect NotFoundErrors to be 404s. But if what can't be found is a nested part of a request object, shouldn't it be a 400 because the data is bad? If so, how do we differentiate between "route doesn't exist" and "your data is bad because it points to something that doesn't exist"?
|
We discussed the same thing, and came to the conclusion that the 404 is still a better error message than 500 UnknownError. The next step is having a strategy for the validation of constraints that changes the 404 to 400. |
chriswk
pushed a commit
that referenced
this pull request
Apr 28, 2023
When adding a strategy using a context field that did not exist, we threw an unknown error. This changes to throw NotFoundError so that our users can better know what they did wrong.
thomasheartman
pushed a commit
that referenced
this pull request
Apr 28, 2023
When adding a strategy using a context field that did not exist, we threw an unknown error. This changes to throw NotFoundError so that our users can better know what they did wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When adding a strategy using a context field that did not exist, we threw an unknown error.
This changes to throw NotFoundError so that our users can better know what they did wrong.