Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: anonymize email in event payload #3672

Merged
merged 2 commits into from
May 3, 2023

Conversation

nunogois
Copy link
Member

@nunogois nunogois commented May 3, 2023

https://linear.app/unleash/issue/2-987/unleash-is-not-correctly-anonymizing-emails-in-the-project-events

Context: https://unleash-internal.slack.com/archives/C048ELND3QD/p1683097636083299

We should also anonymize email fields in data and preData of event objects when anonymiseEventLog is enabled.

image

@nunogois nunogois requested a review from ivarconr May 3, 2023 08:07
@vercel
Copy link

vercel bot commented May 3, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
unleash-docs ⬜️ Ignored (Inspect) May 3, 2023 8:17am
unleash-monorepo-frontend ⬜️ Ignored (Inspect) May 3, 2023 8:17am

@nunogois nunogois enabled auto-merge (squash) May 3, 2023 08:08
@nunogois nunogois disabled auto-merge May 3, 2023 08:08
@nunogois nunogois changed the title Fix anonymize emails event payload fix: anonymize email in event payload May 3, 2023
@nunogois nunogois enabled auto-merge (squash) May 3, 2023 08:08
Copy link
Member

@sighphyre sighphyre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one! LGTM

@nunogois nunogois merged commit fb999e6 into main May 3, 2023
11 checks passed
@nunogois nunogois deleted the fix-anonymize-emails-event-payload branch May 3, 2023 09:46
nunogois added a commit that referenced this pull request May 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

3 participants