task: Add Unit test result check task #3695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
sighphyre
approved these changes
May 5, 2023
|
After enabling |
Comment on lines
33
to
35
| - run: yarn install --frozen-lockfile --ignore-scripts | ||
| - run: yarn build | ||
| - run: yarn build:frontend |
There was a problem hiding this comment.
This is out of date, build is already building the frontend, but if we want to build frontend, I think we also need to remove --ignore-scripts (I'm not sure why we have them)
.github/workflows/build_prs.yaml
Outdated
| @@ -19,5 +19,4 @@ jobs: | |||
| cache: 'yarn' | |||
| - run: yarn install --frozen-lockfile --ignore-scripts | |||
| - run: yarn lint | |||
| - run: yarn build:backend | |||
| #- run: yarn build:frontend # not needed | |||
| - run: yarn build | |||
There was a problem hiding this comment.
Not sure if this is intended, but build will also build the frontend, in which case we need to remove --ignore-scripts from yarn install to also install frontend dependencies
chriswk
force-pushed
the
task/addTestReporting
branch
from
d298b04
to
926e7cc
Compare
chriswk
force-pushed
the
task/addTestReporting
branch
from
6fb4e29
to
cb83b9b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After a Team Retro, one of our squads felt like we needed more data on our test suites. This is the first effort to make our test results easier to grab. It uses the test-reporter action to add a github check to our main build and PR builds with our test results.
This at least should make it easier to parse which tests are failing. However, it does not give us trends. So it does not yet make it easier to decide which tests are flaky just from a quick view.