-
-
Notifications
You must be signed in to change notification settings - Fork 655
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: extend group documentation to include information on setting root roles #3696
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Huh. Spec tests have found an issue. I am 99.99% sure it's unrelated given the test but really nice to see they found something! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Solid work 💪🏼 I've got one suggestion and one discussion point, but I'll leave it up to you what you wanna do.
@@ -136,10 +136,15 @@ A user group consists of the following: | |||
- a **description** (optional) | |||
- a **list of users** (required) | |||
- a list of SSO groups to sync from (optional) | |||
- a root role associated with the group (optional) (only available in **Unleash 5.1** and later) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm unsure about whether this should have the "(only available in ...)" or not. I'm leaning towards yes because it's unreleased for now, but I don't actually think it should stay there. So ... maybe no? What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I'm also in two minds. We've used this pattern in the past but I'm not 100% sure it's working for us since we apparently never go clean these things up.
That being said, I don't want users to find the docs and then ask why things don't work the way the docs say they should so while I don't like it, I think it should stay
We do seem to be pretty consistent with these version strings in the docs, though, could we script something to check this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, I'm happy to do either, so I'll leave it up to you.
We do seem to be pretty consistent with these version strings in the docs, though, could we script something to check this?
Depends on what you're thinking about? We can definitely script things, but what do you want to check exactly?
Co-authored-by: Thomas Heartman <thomas@getunleash.ai>
This adds documentation to the RBAC section on how to use root roles on groups and updates a few screenshots for the group pages.