Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: anonymise PII fields in user access if flag is set #3773

Merged
merged 1 commit into from
May 15, 2023

Conversation

chriswk
Copy link
Contributor

@chriswk chriswk commented May 15, 2023

What

In the demo when listing possible users to grant access to your project, we inadvertently expose emails when listing users you can grant access to. This PR anonymises the access list on the way out.

@vercel
Copy link

vercel bot commented May 15, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Updated (UTC)
unleash-docs ⬜️ Ignored (Inspect) May 15, 2023 11:45am
unleash-monorepo-frontend ⬜️ Ignored (Inspect) May 15, 2023 11:45am

Copy link
Member

@sighphyre sighphyre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@chriswk chriswk merged commit e5e4d52 into main May 15, 2023
11 checks passed
@chriswk chriswk deleted the task/anonymisePossiblePII branch May 15, 2023 12:12
chriswk pushed a commit that referenced this pull request May 15, 2023
### What
In the demo when listing possible users to grant access to your project,
we inadvertently expose emails when listing users you can grant access
to. This PR anonymises the access list on the way out.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants