Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow null checker to not fail if it gets no output #3779

Merged
merged 4 commits into from
May 16, 2023

Conversation

sighphyre
Copy link
Member

@sighphyre sighphyre commented May 16, 2023

What

Patches the build scripts so that the null checker doesn't fail

@vercel
Copy link

vercel bot commented May 16, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
unleash-docs ⬜️ Ignored (Inspect) May 16, 2023 7:51am
unleash-monorepo-frontend ⬜️ Ignored (Inspect) May 16, 2023 7:51am

@github-actions
Copy link

No null checks were emitted from this patch. This is likely because no backend code was changed.

@github-actions
Copy link

After enabling strictNullChecks this PR would be increasing the number of null check errors from to .
Make sure your branch is up-to-date with main and check the diff in the console output to pinpoint the offending files.

@Unleash Unleash deleted a comment from github-actions bot May 16, 2023
@Unleash Unleash deleted a comment from github-actions bot May 16, 2023
@gastonfournier gastonfournier merged commit bd53193 into main May 16, 2023
9 checks passed
@gastonfournier gastonfournier deleted the fix/allow-null-checker-to-handle-no-output branch May 16, 2023 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants