Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: message banner (variants) #3788

Merged
merged 9 commits into from
May 18, 2023
Merged

Conversation

nunogois
Copy link
Member

@nunogois nunogois commented May 16, 2023

Tackles the 2 tasks above.

Adapts our FlagResolver logic to support variants, so we can use them for our message banner project but also anything else in the future. Also adapts MessageBanner to the new logic.

  • Add support for variants in FlagResolver;
  • Adapt MessageBanner to a variants flag;
  • Adds sticky support for the MessageBanner;
  • Adds our first variants flag to uiConfig and experimental: messageBanner;
  • Adds a variant-flag-schema to make it easy to represent the variant output that we specify in uiConfig;
  • Adapts experimental to be able to represent default variants while still maintaining type safety;
  • Adds helpers to make it easy to use variants in our project, such as getVariantValue and the useVariant hook;
  • Adapts and adds new tests in flag-resolver.test.ts;

Notes

image

@vercel
Copy link

vercel bot commented May 16, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
unleash-monorepo-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 17, 2023 1:29pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
unleash-docs ⬜️ Ignored (Inspect) Visit Preview May 17, 2023 1:29pm

Copy link
Contributor

@gastonfournier gastonfournier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG!

@nunogois nunogois merged commit db61a8a into main May 18, 2023
16 checks passed
@nunogois nunogois deleted the feat-message-banner-flag-variant branch May 18, 2023 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants