-
-
Notifications
You must be signed in to change notification settings - Fork 658
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: message banner (variants) #3788
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
3b5c5aa
to
ec3f057
Compare
ceada7c
to
7643119
Compare
gastonfournier
approved these changes
May 18, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LG!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tackles the 2 tasks above.
Adapts our
FlagResolver
logic to support variants, so we can use them for our message banner project but also anything else in the future. Also adapts MessageBanner to the new logic.FlagResolver
;MessageBanner
to a variants flag;sticky
support for theMessageBanner
;uiConfig
andexperimental
:messageBanner
;variant-flag-schema
to make it easy to represent the variant output that we specify inuiConfig
;experimental
to be able to represent default variants while still maintaining type safety;getVariantValue
and theuseVariant
hook;flag-resolver.test.ts
;Notes
The(50ccf60);as PayloadType
assertions need 3.20.0 unleash-client-node#454 since it includes fix: specify all payload types and export them unleash-client-node#452Enterprise needs a PR that will follow soon;