Basic bulk update implementation #3794
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ |
kwasniew
commented
May 17, 2023
| user?: User, | ||
| shouldActivateDisabledStrategies = false, | ||
| ): Promise<void> { | ||
| await Promise.all( |
There was a problem hiding this comment.
I will test later if sequential creation is needed or if we can run it in parallel
There was a problem hiding this comment.
Also I will do error handling once I have the UI and transactions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the changes
First draft of the bulk toggle on/off with Promise.all and no optimizations. This is to get it functional and available for integration with the UI.
In the followup PR I will implement transactions and error handling, but only once we have the UI.
Important files
Discussion points