Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bulk enabled disable #3797

Merged
merged 6 commits into from
May 18, 2023
Merged

Bulk enabled disable #3797

merged 6 commits into from
May 18, 2023

Conversation

kwasniew
Copy link
Contributor

@kwasniew kwasniew commented May 17, 2023

About the changes

Enable and disable buttons
Screenshot 2023-05-17 at 15 34 54

Enable modal
Screenshot 2023-05-17 at 15 35 01

Disable modal
Screenshot 2023-05-17 at 15 35 08

Most of the enable and disable code is similar but I prefer not to DRY it at this point as the abstraction may be less readable.

Followup PRs:

  • change request info banner
  • info banner how many features are already enabled/disabled
  • tests

Important files

Discussion points

@vercel
Copy link

vercel bot commented May 17, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
unleash-monorepo-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 18, 2023 5:58am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
unleash-docs ⬜️ Ignored (Inspect) May 18, 2023 5:58am

@github-actions
Copy link

After enabling strictNullChecks this PR would be increasing the number of null check errors from 292 to 5776.
Make sure your branch is up-to-date with main and check the diff in the console output to pinpoint the offending files.

@github-actions
Copy link

After enabling strictNullChecks this PR would be increasing the number of null check errors from 292 to 5776.
Make sure your branch is up-to-date with main and check the diff in the console output to pinpoint the offending files.

Copy link
Contributor

@sjaanus sjaanus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kwasniew kwasniew enabled auto-merge (squash) May 18, 2023 06:07
@kwasniew kwasniew merged commit 2487b99 into main May 18, 2023
16 checks passed
@kwasniew kwasniew deleted the bulk-enabled-disable branch May 18, 2023 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants