Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: change plausible events to be more specific at the top level #3810

Merged
merged 2 commits into from
May 19, 2023

Conversation

nunogois
Copy link
Member

Splits the demo event into multiple more specific events so it's easier to track on Plausible (fix (none) in Plausible).

@vercel
Copy link

vercel bot commented May 19, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
unleash-monorepo-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 19, 2023 1:41pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
unleash-docs ⬜️ Ignored (Inspect) May 19, 2023 1:41pm

@github-actions
Copy link

After enabling strictNullChecks this PR would be increasing the number of null check errors from 293 to 5811.
Make sure your branch is up-to-date with main and check the diff in the console output to pinpoint the offending files.

@github-actions
Copy link

After enabling strictNullChecks this PR would be increasing the number of null check errors from 293 to 5811.
Make sure your branch is up-to-date with main and check the diff in the console output to pinpoint the offending files.

Copy link
Contributor

@nicolaesocaciu nicolaesocaciu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nunogois nunogois merged commit 0c538f0 into main May 19, 2023
16 checks passed
@nunogois nunogois deleted the fix-new-plausible-events branch May 19, 2023 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants