You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improves the behavior of disabling password based login by adding some relevant information and a confirmation dialog with a warning. This felt better than trying to disable the toggle, by still allowing the end users to make the decision, except now it should be a properly informed decision with confirmation.
Password based administrators: Admin accounts that have a password set;
Other administrators: Other admin users that do not have a password. May be SSO, but may also be users that did not set a password yet;
Admin service accounts: Service accounts that have the admin root role. Depending on how you're using the SA this may not necessarily mean locking yourself out of an admin account, especially if you secured its token beforehand;
Admin API tokens: Similar to the above. If you secured an admin API token beforehand, you still have access to all features through the API;
Each one of them link to the respective page inside Unleash (e.g. users page, service accounts page, tokens page...);
If you try to disable and press "save", and only in that scenario, you are presented with the following confirmation dialog:
After enabling strictNullChecks this PR would be increasing the number of null check errors from 293 to 5814. Make sure your branch is up-to-date with main and check the diff in the console output to pinpoint the offending files.
After enabling strictNullChecks this PR would be increasing the number of null check errors from 293 to 5814. Make sure your branch is up-to-date with main and check the diff in the console output to pinpoint the offending files.
After enabling strictNullChecks this PR would be increasing the number of null check errors from 293 to 5814. Make sure your branch is up-to-date with main and check the diff in the console output to pinpoint the offending files.
## About the changes
This action started to fail and despite being safe to ignore it's still
annoying. I'm disabling it for now until I can look into what's going on
with it
Example:
#3829 (comment)
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://linear.app/unleash/issue/2-1071/prevent-users-from-disabling-password-authentication-when-there-are-no
Improves the behavior of disabling password based login by adding some relevant information and a confirmation dialog with a warning. This felt better than trying to disable the toggle, by still allowing the end users to make the decision, except now it should be a properly informed decision with confirmation.
Each one of them link to the respective page inside Unleash (e.g. users page, service accounts page, tokens page...);
If you try to disable and press "save", and only in that scenario, you are presented with the following confirmation dialog: